Open Jasha10 opened 1 year ago
OmegaConf.merge
does not exhibit the same failure mode.
I feel that OmegaConf.update
's behavior should be consistent with that of OmegaConf.merge
: calling update
should result in a node out.child
that is a non-None structured config backed the Child
class.
I feel that OmegaConf.update's behavior should be consistent with that of OmegaConf.merge: calling update should result in a node out.child that is a non-None structured config backed the Child class.
Dunno, that would be an insert, not an update.
Describe the bug The
OmegaConf.update
method throws anAssertionError
when thekey
argument passed toOmegaConf.update
points inside of aDictConfig
instance whose_content
isNone
.To Reproduce
Expected behavior I think OmegaConf should fail gracefully (or maybe not fail at all) in this situation rather than throwing an AssertionError.
Additional context
Edit:
Here is the full traceback:
```text $ OC_CAUSE=1 python repro2.py Traceback (most recent call last): File "/home/homestar/dev/mrepo/pysc/repro2.py", line 17, in