omry / omegaconf

Flexible Python configuration system. The last one you will ever need.
BSD 3-Clause "New" or "Revised" License
1.91k stars 104 forks source link

unsafe_merge: detect value with no root #1088

Open Jasha10 opened 1 year ago

Jasha10 commented 1 year ago

Closes #1087.

This PR addresses an edge-case where AssertionError is raised during a call to OmegaConf.unsafe_merge.

This PR is marked as a draft:

mohammad7t commented 1 month ago

Hi @omry ,

Thank you for creating this PR. I'm wondering if there is any blocker for merging this PR, that I could potentially help resolving?