Closed Jasha10 closed 1 year ago
lgtm, please fix the lint issue.
Also, what's with the circular import warnings?
I've rebased to fix the lint.
Also, what's with the circular import warnings?
It's just that _impl.py
imports from _utils.py
and _utils.py
imports from _impl.py
.
The warning comes from a CodeQL CI workflow added in PR #1029. I'm not sure how to disable the circular import warning specifically.
It's just that
_impl.py
imports from_utils.py
and_utils.py
imports from_impl.py
.The warning comes from a CodeQL CI workflow added in PR #1029. I'm not sure how to disable the circular import warning specifically.
Why is utils importing from impl.py? (and where is it happening?) It feels like utils should be low level helpers that do not depend on implementation details.
Oh, I guess _util
isn't importing from _impl
directly.
My guess is that the lint is referring to import statements within function calls, e.g.:
Ah. Those functions do seem like they belong higher up the import stack.
Hmm, think we should move them to _impl.py
?
Edit: It looks like Hydra imports several of these functions directly from _utils
.
The
OmegaConf.resolve
function was erroring when used with a custom resolver that returns a dict or list.Here's a minimal repro:
Closes #1092.