search

omry / omegaconf

Flexible Python configuration system. The last one you will ever need.
BSD 3-Clause "New" or "Revised" License
1.91k stars 104 forks source link

Update pre-commit hooks and drop support for Python 3.6 & 3.7 #1109

Closed odelalleau closed 11 months ago

odelalleau commented 1 year ago

Fixes #1108

This PR updates pre-commit hooks to the latest current versions of isort / black / flake8 / mypy, and ensures we can run all these tools in the repository without any complaint (which also required dropping support for Python 3.6 & 3.7)

odelalleau commented 1 year ago

@omry any objection to bumping the min version requirement to 3.8? Recent versions of black, etc. have all moved to 3.8.

odelalleau commented 1 year ago

Converting to draft until the move to 3.8 is approved

odelalleau commented 1 year ago

@omry thoughts on enforcing Python >= 3.8?

omry commented 1 year ago

lgtm. FYI: if you want my attention ping me on a different channel.

odelalleau commented 11 months ago

Un-drafting as I believe it's ready now.

Next step on my side: doing something similar in Hydra (may take a few more weeks as I'm working on it quite sparingly).

Edit: actually Hydra already dropped 3.6 (https://github.com/facebookresearch/hydra/pull/2523)

odelalleau commented 11 months ago

@Jasha10 & @omry I would like to get at least one official approval on the updated PR before merging -- thanks! (no rush)