search

omry / omegaconf

Flexible Python configuration system. The last one you will ever need.
BSD 3-Clause "New" or "Revised" License
1.91k stars 104 forks source link

Properly escape interpolation-like strings in resolved configs #1113

Open odelalleau opened 1 year ago

odelalleau commented 1 year ago

Fixes #1112 Fixes #1081

This is a draft PR for several reasons:

  1. It needs tests + news fragment
  2. It is built on top of #1109 that needs to be merged first
  3. The behavior of to_container() and to_object() needs to be looked at (see #1120)

Note that this is a breaking change, but it can be argued that the previous behavior was a bug (all tests pass).

omry commented 1 year ago

I think this needs tests to show what it's actually doing and to ensure it does not break in the future. Also, worth considering any performance impact.

odelalleau commented 1 year ago

I think this needs tests to show what it's actually doing and to ensure it does not break in the future.

Oh yes (see point 1 above)

Also, worth considering any performance impact.

I need to think about it a bit more, but I don't believe this is an issue. Will keep it in mind though.

MatteoVoges commented 1 year ago

Hey I noticed a breaking change with this. See full description of it here: https://github.com/omry/omegaconf/issues/1112#issuecomment-1678573449