Open odelalleau opened 1 year ago
I think this needs tests to show what it's actually doing and to ensure it does not break in the future. Also, worth considering any performance impact.
I think this needs tests to show what it's actually doing and to ensure it does not break in the future.
Oh yes (see point 1 above)
Also, worth considering any performance impact.
I need to think about it a bit more, but I don't believe this is an issue. Will keep it in mind though.
Hey I noticed a breaking change with this. See full description of it here: https://github.com/omry/omegaconf/issues/1112#issuecomment-1678573449
Fixes #1112 Fixes #1081
This is a draft PR for several reasons:
to_container()
andto_object()
needs to be looked at (see #1120)Note that this is a breaking change, but it can be argued that the previous behavior was a bug (all tests pass).