search

omry / omegaconf

Flexible Python configuration system. The last one you will ever need.
BSD 3-Clause "New" or "Revised" License
1.94k stars 105 forks source link

Upgrade Antlr to 4.11 and vendor the runtime #1114

Closed jlopezpena closed 7 months ago

jlopezpena commented 1 year ago

Bumping antlr binary and antlr4-python3-runtime in order to unlock doing the same thing in hydra, following this discussion

jlopezpena commented 9 months ago

It would be useful if someone can try a non-editable install on Windows -- I don't have a windows machine, and am a bit concerned that the "walk-path-and-replace" strategy for finding the submodules might not work due to some path formatting issues (I changed the replacement to use os.path.sep instead of '/', but if os.path.walk prints the path in absolute form instead as relative as in POSIX, the replacement might not work as intended)

shchur commented 8 months ago

Hi @Jasha10, what are the remaining TODOs before this PR can be merged?

Currently, the antlr version incompatibility is major blocker for our project (because of the clash between Omegaconf & https://github.com/Nixtla/statsforecast), so I would be happy to help with any of the remaining TODOs, if possible.

Jasha10 commented 7 months ago

In my opinion this PR is in good shape. I hoped to merge this at about the same time as it's sister PR https://github.com/facebookresearch/hydra/pull/2733 where unfortunately we have a backlog of CI issues that I believe are mostly unrelated to the PR itself (rather just technical debt on the Hydra project).

shchur commented 7 months ago

@Jasha10, thank you for the quick response! Are there some open issues related to the CI failures on the hydra side that I could take a stab at?

odelalleau commented 7 months ago

@Jasha10, thank you for the quick response! Are there some open issues related to the CI failures on the hydra side that I could take a stab at?

There are no open issues but you can basically look at recent open PRs on Hydra to check what's failing.

Jasha10 commented 7 months ago

@shchur I have made a list: https://github.com/facebookresearch/hydra/issues/2841

Jasha10 commented 7 months ago

Thank you @jlopezpena for taking on this vendoring project. The PR is merged and omegaconf dev release 2.4.0.dev2 is now available on pypi. https://pypi.org/project/omegaconf/2.4.0.dev2/

pip install omegaconf==2.4.0.dev2