search

omry / omegaconf

Flexible Python configuration system. The last one you will ever need.
BSD 3-Clause "New" or "Revised" License
1.91k stars 104 forks source link

[Bug Fix] `OmegaConf.missing_keys(cfg)` may fail if contained customi… #1117

Open kaimo455 opened 1 year ago

kaimo455 commented 1 year ago

…zed resolver field that the depends on some missing fields.

OmegaConf.missing_keys(cfg) may fail if contained customized resolver field that the depends on some missing fields.

kaimo455 commented 1 year ago

For the issue #1118

Jasha10 commented 1 year ago

This PR will need tests before it can be merged. Please consider adding a test based on the example from #1118. You can add the test into the same test file where the other OmegaConf.missing_keys tests are located.

odelalleau commented 11 months ago

Thanks, in addition to tests please also add a news fragment in the news folder with the .bugfix extension.

Jasha10 commented 9 months ago

add a news fragment in the news folder with the .bugfix extension.

Done!