omsf-eco-infra / gha-runner

A simple GitHub Action for creating cloud-based self-hosted runners.
MIT License
0 stars 3 forks source link

MVP(v0.1.0) #8

Closed ethanholz closed 4 months ago

ethanholz commented 5 months ago

This PR aims to provide the minimum needed for building out this GitHub Action for use. There are a couple issues that will need to be closed/created following this PR:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 96.36364% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (970c23e) to head (864e1fd).

Files Patch % Lines
src/gha_runner/__main__.py 94.44% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## =========================================== + Coverage 78.41% 95.74% +17.33% =========================================== Files 3 3 Lines 227 282 +55 =========================================== + Hits 178 270 +92 + Misses 49 12 -37 ``` | [Flag](https://app.codecov.io/gh/omsf-eco-infra/gha-runner/pull/8/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=omsf-eco-infra) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/omsf-eco-infra/gha-runner/pull/8/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=omsf-eco-infra) | `95.74% <96.36%> (+17.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=omsf-eco-infra#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ethanholz commented 5 months ago

I would like to note that the failure on codecov is not necessarily representative of the changes made as the testable, non-infra provisioning code is tested __main__.py and is an increase from before.

ethanholz commented 5 months ago

@dwhswenson I believe that I have updated the docs/README to better reflect usage. Do these changes make sense?