search

omsi6 / omsi6.github.io

Incremental games and tools for them.
https://omsi6.github.io/
19 stars 82 forks source link

Action Stories for 20 Short and 10 Long Quests unlocked too early #60

Open EdwardMcCants opened 4 years ago

EdwardMcCants commented 4 years ago

Describe the bug In a game that got to 5% People Met, I performed a Short Quest 5 times (once per run), and when I looked at the Short Quest Story both story segments were unlocked

Version 0.94d

To Reproduce Steps to reproduce the behavior:

  1. Load my game.
  2. Observe that the short question action story requirements are not met, but see the story anyway.

Expected behavior I expect to not see the final Action Story for Short Quest until I've gotten them all.

Savefile https://pastebin.com/GhwjjGsV

A bit later I in the game, I found: image

Amfales commented 4 years ago

Hello, I'm not sure if you're still following this, but I think I found the problem. Did you import an empty string to reset your progress from a save that you had made it further in? It seems that importing to reset doesn't properly update the storyReqs variable, leaving whatever variables were previously there. This isn't noticeable at first because most of the initial story requirements draw from the actual town stats. Only the more "complicated" story requirements would be affected. I could make a PR that will fix it in the future, but I don't think there would be a way to fix currently bugged behavior.

EdwardMcCants commented 4 years ago

I know that I had reset the game. Given that I don't see a hard-reset button, I very likely did an empty import to reset.