search

omtetra / openmentor-grails

OpenMentor, ported to Grails
3 stars 3 forks source link

Improve documentation in AssessmentService #10

Closed morungos closed 12 years ago

morungos commented 12 years ago

The code for the AssessmentService was written in a hurry, and needs documenting extensively and fixing in a few places. The floating point values should optionally (by configuration) be transformed by rounding, so that the comparisons make sense.

morungos commented 12 years ago

The problem is not simply the documentation, although that is an issue. There are also integration issues. There really ought to be an EvaluationScheme object used by the AssessmentService. There is one, but right now it isn't used. The StandardEvaluationScheme ought to provide the basic weights, and these will probably simply be drawn from the configuration, removing the ConfigurationHolder from the AssessmentService. Adding some more tests will help with this, as testing was, to be honest, very weak.