omuse-geoscience / omuse

The Oceanographic Multi-purpose Software Environment: a package for multi-physics and multi-scale earth science simulations.
Apache License 2.0
18 stars 11 forks source link

POP needs 2 states for a restart #72

Open Sbte opened 1 year ago

Sbte commented 1 year ago

OMUSE only has support for loading a single POP state when doing a restart from a previous run. This state is used for both oldtime and curtime. This seems wrong because POP uses a leap-frog scheme, which needs two consecutive states for any update of a different variable. The restart does work, but it takes some time before POP reaches a statistical steady state again, which is undesirable. Support should be added for writing and reading both consecutive states. This should be optional.

esclapez commented 1 year ago

@Sbte I was checking this issue and it seems that both old and current states are stored together in the POP restart file. I've done a basic restart test and found zero difference from restarting. My test case was very basic, so I might be missing something. Can you provide more information on the case exhibiting differences ? Thanks

Sbte commented 1 year ago

POP does (it is widely used in climate modelling, so it works), OMUSE does not. The interface doesn't have any way to access, store or restore the old state.