search

omxhealth / drugbank-sample-apps

Sample apps for the DrugBank API
The Unlicense
5 stars 1 forks source link

fully dockerize all sample apps #38

Closed agentdave closed 2 years ago

agentdave commented 2 years ago

This adds a Dockerfile and supporting files for setting up the php app via Docker. It also adds a docker-compose.yml with default settings (image names, ports, etc.) to make it easier to fire up each app.

petreman commented 2 years ago

I haven't looked at the sample apps for a long time but I really like this! When I added the initial configurations almost 2 years ago it was the first time I had ever worked with Docker and It was also just before my internship ended so I quickly tried to throw something that worked together. I'm not much more experienced with Docker than I was at the time so I can't offer extensive insight there, but everything looks good to me. I can't see any glaring issues so if everything still works awesomely then let's merge it in!