omz / AppSales-Mobile

App Sales allows iPhone and Mac App Store developers to download and analyze their daily and weekly sales reports from iTunes Connect.
http://omz-software.com
1.89k stars 407 forks source link

Icons for new apps not always showing up in Dashboard list #261

Open jasondmichaelson opened 10 years ago

jasondmichaelson commented 10 years ago

After doing some debugging, I've found that the problem lies in Classes/DashboardAppCell.m, line 63:

if (self.product.parentSKU) {

It appears that parentSKU is no longer always nil for non-in-app-purchased products, instead it is a single space, which is coming from the actual report from apple.

I changed it to

if (self.product.parentSKU && self.product.parentSKU.length > 1) {

and my new app icons appear.

I'd submit a pull request from my own fork, but I still have the promo code, payment, and review code base there. and the parentSKU change affects promo codes and reviews as well.

ddaddy commented 10 years ago

Excellent, thanks :) I've added this to my fork which has all the bug fixes but on the old style.