nicolasgomollon
commented
8 years ago Thanks for this! I ran into the same exact issue, and couldn’t figure out what was going on!
I just incorporated your idea into my copy of this project so I can be alerted about these kinds of things in the future:
In ReportDownloadOperation.m line 60:
NSMutableDictionary *errors = [[NSMutableDictionary alloc] init];…and replaced line 177 in ReportDownloadOperation.m with:
// The message "Daily Reports are only available for past 365 days. Please enter a new date."
// just means that the report in question has not yet been released.
// We can safely ignore this error and move on.
if ([errorMessage rangeOfString:@"past 365 days"].location == NSNotFound) {
NSLog(@"%@ -> %@", reportDateString, errorMessage);
NSInteger year = [[reportDateString substringWithRange:NSMakeRange(0, 4)] intValue];
NSInteger month = [[reportDateString substringWithRange:NSMakeRange(4, 2)] intValue];
NSInteger day = [[reportDateString substringWithRange:NSMakeRange(6, 2)] intValue];
NSDateComponents *components = [[NSDateComponents alloc] init];
[components setYear:year];
[components setMonth:month];
[components setDay:day];
NSDate *reportDate = [[NSCalendar currentCalendar] dateFromComponents:components];
NSMutableDictionary *reportTypes = [[NSMutableDictionary alloc] initWithDictionary:errors[errorMessage]];
NSMutableArray *reports = [[NSMutableArray alloc] initWithArray:reportTypes[dateType]];
[reports addObject:reportDate];
reportTypes[dateType] = reports;
errors[errorMessage] = reportTypes;
}…and right before line 225 in ReportDownloadOperation.m:
dispatch_async(dispatch_get_main_queue(), ^{
NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init];
dateFormatter.timeStyle = NSDateFormatterNoStyle;
dateFormatter.dateStyle = NSDateFormatterShortStyle;
for (NSString *error in errors.allKeys) {
NSString *message = error;
NSDictionary *reportTypes = errors[error];
for (NSString *reportType in reportTypes.allKeys) {
message = [message stringByAppendingFormat:@"\n\n%@ Reports:", reportType];
for (NSDate *reportDate in reportTypes[reportType]) {
message = [message stringByAppendingFormat:@"\n%@", [dateFormatter stringFromDate:reportDate]];
}
}
UIAlertView *alertView = [[UIAlertView alloc] initWithTitle:NSLocalizedString(@"Error", nil)
message:message
delegate:nil
cancelButtonTitle:NSLocalizedString(@"OK", nil)
otherButtonTitles:nil];
[alertView show];
}
});This code generates a summarized error alert for each distinct error message encountered:
ddaddy
statcoder
Morpheus2002
pupasani
After installing the latest version of this app and deleting sales reports from October 26 and later I tried to redownload those reports. The app appeared like it was downloading and processing the reports but in the end, there were no bars for those days.
Then I noticed a bunch of errors in the console about the fact that my account uses two-factor authentication and I should create an app-specific app id.
So I guess this is an enhancement request that could help anyone complaining that this app isn't downloading any new reports. The app didn't indicate there was any error during the download. It would be nice if this app could present any download errors instead of silently ignoring them. Such an error message would have saved me some head scratching trying to figure out why I wasn't getting any new reports.
BTW - in my case I created app-specific app id and updated the password in this app with the new password and it started working again.