search

omz / Pythonista-Issues

Issue tracker for Pythonista (iOS)
168 stars 14 forks source link

iPhone X support #483

Open levi opened 6 years ago

levi commented 6 years ago

UI needs update to fit the new height of the iPhone X.

iamrecursion commented 6 years ago

This would be really great to see. It's pretty much the one app that I still use frequently that hasn't updated,

ijkim88 commented 6 years ago

Anyone else have issues with the beta crashing whe loading on the iPhone X

omz commented 6 years ago

@ijkim88 I’d be very interested in a crash report. Also, does it crash immediately, or hang for a bit? Does it go away if you reboot the device?

ijkim88 commented 6 years ago

@omz It crashes immediately. Also tried reboting, but no luck. I've attached a clip here.

pythonista_load_crash

I couldn't find a Pythonista log in Settings > Privacy > Analytics > Analytics Data. Is there another way I can pull the crash report?

ijkim88 commented 6 years ago

Just tried some of the older builds. 311016 & 311015 did not work, but 311014 seems to load the app fine.

omz commented 6 years ago

@ijkim88 Thank you. Could you try launching Pythonista by entering pythonista3:// in Safari? This should launch the app without restoring the tabs of the previous session. Maybe the crash has something to do with that, but it's just a guess.

ijkim88 commented 6 years ago

@omz Hmm, I don't know what happened. But I just updated to iOS 11.2.1 and re-downloaded Pythonista 3 (Build 311016) and it loaded fine. Not sure if it's related to restoring tabs of the previous session, but it looks to work fine now. If I see it again, I can file a new issue.

ijkim88 commented 6 years ago

@levi @iamrecursion As for the originally reported issue for this ticket, the UI height looks fine to me on the iPhone X. You guys may want to confirm as well.

omz commented 6 years ago

@ijkim88 I'm glad it works for you now, though crashes of this sort are particularly frustrating for me. One more question: Before you re-downloaded the app, did you customize pythonista_startup at all? I'm asking because build 311015 changed the way the startup script is executed, so it could be related to that (still just a guess).

levi commented 6 years ago

This is what the UI looks like on the latest App Store build. The app hasn’t been optimized for iPhone X screen sizes, leaving black bars added to the top and bottom of the UI.

b0526d1c-d7cb-4243-9d22-9e04b09a02a4

ijkim88 commented 6 years ago

@omz I haven't touched pythonista_startup. It might be related to the open tabs, but then again I don't usually have multiple tabs open in Pythonista... I'll keep an eye if this issue pops up again with future beta releases.

ijkim88 commented 6 years ago

@levi The beta builds looks fine on the iPhone X, so I assume the next App Store release should fix it.

dchevell commented 5 years ago

This should be closed as fixed.