Issue 250 complete permission checks

on-site / grantzilla

A grant application management web app

MIT License

10 stars 11 forks source link

Issue 250 complete permission checks #260

Closed scottjones closed 8 years ago

scottjones commented 8 years ago

Fixes #250

Ensures you're an admin user to view/edit users
Ensures you're an admin user to view/edit agencies
Fixes editing users so that it works rather than just editing yourself
Adds factory girl and request specs for validating permissions.

Note that I've added the factories all into a single file. This is recommended by the folks from thoughtbot and is something that I'm finding I enjoy.

joedean commented 8 years ago

I added comments in the code. Overall looks great! Thanks for adding all the request specs and adding FactoryGirl was a must! :smiley:

joedean commented 8 years ago

@lamplus I'm leaving you in charge of merging in all pull requests, since you are the maintainer of the repo.

scottjones commented 8 years ago

@lamplus pushed a few more commits here that should address @joedean's comments.