search

on2-dev / nasc-vscode-mac-touchbar

A customization for your the macbook pro touch bar buttons with features for VSCode.
MIT License
115 stars 34 forks source link

fixed goToDefinition command #42

Closed zeevl closed 4 years ago

zeevl commented 4 years ago

the goToDefinition command started failing for me.

Upon further investigation, I'm not sure why it was doing all the work it was doing, so I replaced it with a simple call to vscode.commands.executeCommand('editor.action.goToDeclaration');

thomas-darling commented 4 years ago

@felipenmoura This is probably one of the most used features, and it's been broken for a while now. If this fix works, it would be really great to get it merged and released soon 🙂

felipenmoura commented 4 years ago

Hi Yup, I am having trouble loging into the extensions platform! We have some updates and even some PRs merged, but I can't publish it! I'm in touch with MS team and opened an issue. Fingers crossed to solve this asap!

linonetwo commented 4 years ago

Is there anything we can help? @felipenmoura

This has been long waited for, maybe we can send mails to MS to support you?

linonetwo commented 4 years ago

@felipenmoura As you can login to Github, can you merge this PR first?

Lewis2z commented 4 years ago

@felipenmoura Thanks for fixing it on here. Is there any update on when the fix will be published?

sammccants commented 4 years ago

Yup, I am having trouble loging into the extensions platform! We have some updates and even some PRs merged, but I can't publish it! I'm in touch with MS team and opened an issue. Fingers crossed to solve this asap!

@felipenmoura has there been any progress with getting a new release out? I would love to have this update!