Mage randomization for expeditions

[therobbot]

Something seems wrong with the mages randomization for expeditions. I always get the same set of mages. It seems they only get selected from one expansion and mages from other expansions are only added if there are not enough in one expansion. This is totally different from the behavior in the single game Randomizer. Can you please have a look at this.

Apart from this, this is an awesome app!

[on3iro]

@therobbot thanks for the feedback and the bug report. Can you get into a bit more detail what you exactly did? I created a few expeditions and while I was able to create results with mages from different expansions, there seems to be a tendency to roll a lot of war eternal mages. Can you confirm this? I will definitely look into this and also check if this is still the case with our current beta build.

Edit: Could you please have a look at our beta build - it seems that we already have fixed this with this build https://5e90772a9dcf91189f5e71e4--aer.netlify.com/expeditions We will hopefully finish the next AER version soon and therefore also release this fix.

[therobbot]

I don't have War Eternal. In my case, I selected the complete first wave (with small box expansions) and New Age.

I created 16 expeditions and get results that don't seem properly randomized, namely:

3x Lash, Mist, Kadir, Phaedraxa (all from AE) 2x Soskel, Gygar, Taqren, Sahala (all from NA) 2x Brama, Jian, Kadir, Lash (all from AE) 2x Phaedraxa, Mist, Xaxos, Nym (all but one from AE) 2x Sahala, Zhana, Gygar, Reeve (NA and D) 1x Mist, Phaedraxa, Xaxos, Lash (all from AE) 1x Kadir, Mist, Lash, Jian (all from AE) 1x Zhana, Reeve, Sahala, Nym (NA and D) 1x Nym, Reeve, Xaxos, Zhana (AE and D) 1x Talix, Rhia, Taqren, Soskel (all from NA)

This is far from what I would expect from a randomized distribution. I have yet to see AE and NA mixed together.

Can you point me to where in the code you do the randomization for the expeditions? Then I could take a look myself.

[on3iro]

Can you point me to where in the code you do the randomization for the expeditions? Then I could take a look myself.

@therobbot could you please check the beta branch first. https://5e90772a9dcf91189f5e71e4--aer.netlify.com/expeditions

The release build you are currently using is quite different from the actual code base, as I changed a ton of code in the last few months. While refactoring I made lots of small fixes and am pretty sure that the behavior you describe is no longer apparent in our current beta build. If you could confirm that the beta build works correctly for you, we can move forward.

I had a lot of personal things to do in the last few weeks, which is why 3.0.0 has not yet been released. But knowing there is an issue like this I will definitely try to prioritize the release, so that the fix will soon be live.

[therobbot]

I tried the beta version and it looks as if it fixes the problem. I will test some more but for now it looks good. Thanks.

Theo Salzmann notifications@github.com schrieb am Sa., 9. Mai 2020 13:53:

Can you point me to where in the code you do the randomization for the expeditions? Then I could take a look myself.

@therobbot https://github.com/therobbot could you please check the beta branch first. https://5e90772a9dcf91189f5e71e4--aer.netlify.com/expeditions

The release build you are currently using is quite different from the actual code base, as I changed a ton of code in the last few months. While refactoring I made lots of small fixes and am pretty sure that the behavior you describe is no longer apparent in our current beta build. If you could confirm that the beta build works correctly for you, we can move forward.

I had a lot of personal things to do in the last few weeks, which is why 3.0.0 has not yet been released. But knowing there is an issue like this I will definitely try to prioritize the release, so that the fix will soon be live.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/issues/328#issuecomment-626164285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHYIAIG2WZZMS2FQTMSBUDRQU73JANCNFSM4M4VGLFQ .

[on3iro]

Awesome :) thanks again for reporting the bug. I will try to get 3.0.0 ready asap :+1:

[on3iro]

Just a quick update @therobbot : unfortunately I did not yet have time to finish 3.0.0. I hope to get it done during the next weekend :)

[therobbot]

No problem. I just use beta right now.

Theo Salzmann notifications@github.com schrieb am Do., 21. Mai 2020 09:37:

Just a quick update @therobbot https://github.com/therobbot : unfortunately I did not yet have time to finish 3.0.0. I hope to get it done during the next weekend :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/issues/328#issuecomment-631935573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHYIAKLN3ROIZPOBHYMKM3RSTK4DANCNFSM4M4VGLFQ .

[on3iro]

@therobbot keep an eye on the releases - we will probably release 3.0.0 tomorrow ;)

[therobbot]

Hi Theo,

Cool, thanks. By the way, I have another question. When doing expeditions with the app it seems that new upgraded nemesis cards are added randomly but old ones stay in the barracks. Is this how it's supposed to work? I always read the expedition rules in a way that you always draw new upgraded cards randomly. It kind of makes sense the way the app works because you can then better prepare for it but I wonder how it should be played by the RAW.

I'm any case, thanks for your great work.

Tobias

Theo Salzmann notifications@github.com schrieb am Sa., 23. Mai 2020 18:16:

@therobbot https://github.com/therobbot keep an eye on the releases - we will probably release 3.0.0 tomorrow ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/issues/328#issuecomment-633086005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHYIAN4CPLVQ54FGCEEH63RS7ZHBANCNFSM4M4VGLFQ .

[on3iro]

Hi Tobias,

First of all - thanks for the kind words :)

Now to your question: to be honest I am not 100% sure. I have to read this up someday^^ If this is important to you, you can create a new issue. However it will probably take a while until I look it to it :)

Cheers

Theo

[therobbot]

Hi again,

It's not a big issue really since it is not a big deal to just ignore this and choose them randomly. It's more a case of me wondering if I have been misinterpreting the rules. If you're not sure yourself I will reread the rules and then maybe post a question on bgg to be sure.

Take care,

Tobias

Theo Salzmann notifications@github.com schrieb am So., 24. Mai 2020 09:27:

Hi Tobias,

First of all - thanks for the kind words :)

Now to your question: to be honest I am not 100% sure. I have to read this up someday^^ If this is important to you, you can create a new issue. However it will probably take a while until I look it to it :)

Cheers

Theo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/issues/328#issuecomment-633191855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHYIAKPIDA7RFILQXMEYLDRTDD73ANCNFSM4M4VGLFQ .

[therobbot]

Hi Theo,

I haven't found a possibility to save the expedition state for the randomizer locally to a file. Do I miss something? I can save the expedition but it doesn't save the progress.

And another question: if I start an expedition with a certain expansion subset selected in the settings and then change the settings does the expedition use the old or the new setings?

Thanks

Tobias

Tobias Fritz flabbergasted@gmx.de schrieb am So., 24. Mai 2020 09:33:

Hi again,

It's not a big issue really since it is not a big deal to just ignore this and choose them randomly. It's more a case of me wondering if I have been misinterpreting the rules. If you're not sure yourself I will reread the rules and then maybe post a question on bgg to be sure.

Take care,

Tobias

Theo Salzmann notifications@github.com schrieb am So., 24. Mai 2020 09:27:

Hi Tobias,

First of all - thanks for the kind words :)

Now to your question: to be honest I am not 100% sure. I have to read this up someday^^ If this is important to you, you can create a new issue. However it will probably take a while until I look it to it :)

Cheers

Theo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/issues/328#issuecomment-633191855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHYIAKPIDA7RFILQXMEYLDRTDD73ANCNFSM4M4VGLFQ .

[on3iro]

Hi Tobias,

1. Regarding your first question: There are multiple layers to this:

   • the current state an expedition is in is currently only stored inside the randomizer itself - we are working on a general export #135 , but as it stands this is currently more or less on hold, due to time contraints. So there is now way to completely export and expedition and load it somewhere else. But we will probably introduce something like this in the future
   • when you press the share button next to an expedition, depending on the device you use either your devices share tool will open, or the app will allow you to save an expeditionConfig
   • the thing you share is just a config, this config hast multiple purposes:
     1. it allows you to share an expedition you particularily liked with friends and other users and they can replay it
     2. we have a complex expeditionConfigDSL which allows you to build narrative expeditions similar to the ones provided with new age or outcasts. (technically the DSL allows for far more complex expeditions, with multiple narrative branches etc.) I build an example for the whole new age campaign, you could try out: new age
     3. it allows you to replay expeditions

2. Regarding your second question: Whenever an expedition is created, the app checks, what content you have selected at this point in time and creates as settingsSnapshot for this particular expedition. From this point onward all randomization use the settingsSnapshot instead of your regular settings.

The reason for this is, that we want to keep expeditions consistent and that users don't accidentally mess up their expeditions, by having no content selected etc. Furthermore this allows us to share their config including this snapshot, so that the pool of things to randomize from will always be the same, when other players play the shared expedition, or you duplicate one for yourself.

Hope that helps, let me know if anything is still unclear :)

Kind regards

Theo

[therobbot]

Hey Theo,

Thanks for your reply. Could you point me to where such an export would have to be implemented in the code? Maybe I'll find time to look into it at some point. Wouldn't it at least be quite simple to allow the user to export the site specific browser settings and import them on another browser?

Tobias

Theo Salzmann notifications@github.com schrieb am Mo., 5. Okt. 2020 20:27:

Hi Tobias,

1. Regarding your first question: There are multiple layers to this:

   • the current state an expedition is in is currently only stored inside the randomizer itself - we are working on a general export #135 https://github.com/on3iro/aeons-end-randomizer/issues/135 , but as it stands this is currently more or less on hold, due to time contraints. So there is now way to completely export and expedition and load it somewhere else. But we will probably introduce something like this in the future
   • when you press the share button next to an expedition, depending on the device you use either your devices share tool will open, or the app will allow you to save an expeditionConfig
   • the thing you share is just a config, this config hast multiple purposes:
     1. it allows you to share an expedition you particularily liked with friends and other users and they can replay it
     2. we have a complex expeditionConfigDSL which allows you to build narrative expeditions similar to the ones provided with new age or outcasts. (technically the DSL allows for far more complex expeditions, with multiple narrative branches etc.) I build an example for the whole new age campaign, you could try out: new age https://gist.github.com/on3iro/8cd4980274945b8c759688c6f0ffed4c
     3. it allows you to replay expeditions

2. Regarding your second question: Whenever an expedition is created, the app checks, what content you have selected at this point in time and creates as settingsSnapshot for this particular expedition. From this point onward all randomization use the settingsSnapshot instead of your regular settings.

The reason for this is, that we want to keep expeditions consistent and that users don't accidentally mess up their expeditions, by having no content selected etc. Furthermore this allows us to share their config including this snapshot, so that the pool of things to randomize from will always be the same, when other players play the shared expedition, or you duplicate one for yourself.

Hope that helps, let me know if anything is still unclear :)

Kind regards

Theo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/on3iro/aeons-end-randomizer/issues/328#issuecomment-703808285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHYIAPVXNA2MVCNUK64RCDSJIFXLANCNFSM4M4VGLFQ .

[on3iro]

Hi Tobias,

sure - there are multiple things that would've to be done:

1. Build a button inside the UI to backup the expedition (probably on each item inside the expedition list, above the delete button)
2. Some kind of "import-expedition" button inside the expedition list (we currently only have the "create Expedition" button -> we definitely need some kind of UI-concept for this, before it makes sense to start
3. To export the expedition, we could probably use the same mechanism we use for the sharing (which probably needs some refactoring beforehand) - instead of sharing/saving the expeditionConfig, we just share the expedition itself
4. we need to implement the import, this will be the hardest part, because a few things need to be taken into account:
   1. if the id of the expedition already exists - what should happen? - ideally we ask the user, if he wants to replace the existing expedition
   2. Upon importing we need to make sure, that the expedition is run through all our clientSide-migrations, before it can finally be added to the state again

So this in turn means, that there are quite a few pieces of code you'd have to touch (expeditions are the most involved part of the whole app).

If you need more information, just let me know. However we should continue our discussion on #397 instead, then 👍 :)