search

on4kjm / FLEcli

Multi-platform "Fast Log Entry"(FLE) processing tool
MIT License
32 stars 9 forks source link

Revert "Permit comment after other input on the line (#119)" #125

Closed k0emt closed 8 months ago

k0emt commented 8 months ago

This reverts commit caefd4699441244e8e469df04a402e3df8cc4497. I went back and reviewed this again. I goofed. What I was observing is not the documented intended behavior.

According to the FLE documentation for a comment the # must be in the first position on the line. However, as implemented it permits whitespace before the # (still must be the first non-whitespace character).

The # operator is overloaded. If the # occurs in any other position in the line, it should be used to indicate a Grid Square.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.97%. Comparing base (74f433e) to head (d7d0d49). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ========================================== - Coverage 81.89% 80.97% -0.93% ========================================== Files 17 18 +1 Lines 1370 1030 -340 ========================================== - Hits 1122 834 -288 + Misses 214 162 -52 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jmMeessen commented 8 months ago

I will look into this as soon as possible. Note that I am in the middle of moving 600 km from here, to F-land. Sorry for the delay in reacting.