on4kjm / FLEcli

Multi-platform "Fast Log Entry"(FLE) processing tool
MIT License
32 stars 9 forks source link

Change ADIF comment and programid to say FLEcli instead of FLE. #132

Open nicheath opened 8 months ago

nicheath commented 8 months ago

It makes more sense to me to change lines

https://github.com/on4kjm/FLEcli/blob/1b1c150af4dd82e339bccc89f076e957e5ce30ee/fleprocess/adif_write.go#L38 https://github.com/on4kjm/FLEcli/blob/1b1c150af4dd82e339bccc89f076e957e5ce30ee/fleprocess/adif_write.go#L39

to be

adifList = append(adifList, "ADIF Export for Fast Log Entry CLI by ON4KJM")
adifList = append(adifList, "<PROGRAMID:6>FLEcli")

thoughts?

jmMeessen commented 8 months ago

Well, this is an interesting question. Initially, I wanted to be as close as possible to the original FLE program and "spec". In the beginning, the test was that a given input file would produce the same output with FLE and with FLEcli. I also did not expect to have so many people finding it useful. But changing the programID would be closer to reality. On top of that, I would "own" my own mistakes.

nicheath commented 8 months ago

I don't care about owning mistakes really but I am happy I found a FOSS version of FLE because for us U.S. operators county is important for county hunters. So finding this and being able to add that was great. The change here is nice as it would advertise the app more as ADIFs are exchanged and I believe POTA also tracks stats of what programs are used (you might have to ask the POTA people for the stats though).