Closed jmaas-onoffice closed 1 year ago
@jmaas-onoffice I have some questions about this requirement:
- Is the "GDPR(Checkbox)" a new field or an alternative to "GDPR Status"?
It should be a new field in the category "Special Fields". It's not a real enterprise field, it's only there in the plugin.
We will keep the existing enterprise field with the key "DSGVOStatus", but it will probably not be used anymore in practice.
- The field "GDPR(Checkbox)" is the default field when creating a new Form, right?
That's a good question, we hadn't thought about this. Maybe we can add it as a default using get_privacy_policy_url()
. But this is a nice-to-have, if time runs short, leave it out and keep the defaults as they are right now. We can add this later.
- Are there any requirements for the Privacy Policy page content?
I'm not sure what you mean. Why would we need to know the privacy policy's content? The checkbox's label only needs to be able to link to it, but that's something the user should do.
- The checkbox for "GDPR status" is to select only 1 option or can select multiple options?
The current enterprise field with the key "DSGVOStatus" should stay as it is now with multiple options. But the new field "GDPR (Checkbox)" should only be a checkbox. Was this your question?
@jmaas-onoffice Could you please tell me how to show " I agree to the Privacy Policies"?
@dai-eastgate The idea is that by allowing Markdown labels, the users can add those links in the label. For example:
We need the checkbox for backwards compatibility, since existing labels could include things like *
or [
, so enabling Markdown for everything could break existing labels.
@jmaas-onoffice I added "GDPR(Checkbox)" field and allowed rich text in all labels. You can watch video and give me feedback.
@dai-eastgate Looks good!
When you check it and send the form, does it set the correct field in enterprise for the address? Apart from that, it looks very good. :)
@jmaas-onoffice Could you please tell me When I click on the link, What page does it redirect to?
Oh, sorry! Let's point it to https://wp-plugin.onoffice.com/en/advanced-features/markdown-labels. Currently there is nothing there, but before the release I will add an explanation there.
Please also make that link translatable, so that I can point to the German version in German.
@jmaas-onoffice I fixed, you can watch video and give me feedback.
Looks good, but in your test I'm not sure whether the "normal" is setting the field in enterprise or the new one. As long as the new one also sets the field (even when the other one is not in the form), then it seems good. :)
Discussed in https://github.com/onOffice-Web-Org/oo-wp-plugin/discussions/362