onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

Price on request #492

Closed fredericalpers closed 1 year ago

fredericalpers commented 1 year ago

Discussed in https://github.com/onOffice-Web-Org/oo-wp-plugin/discussions/482

Originally posted by **fredericalpers** April 4, 2023 ### Current state Price on request function can currently not be used. The actual property prices should not be displayed by default if "Price on request" is set to "Yes". At the moment, this is only possible via template adjustments. Currently we have to add the field “preisAufAnfrage” into the $dontEcho and then later into an if-loop so the value “Preis auf Anfrage” will be displayed instead the actual price. ``` $dontEcho = array("objekttitel", "objektbeschreibung", "lage", "ausstatt_beschr", "vermarktungsart", "objektart", "nutzungsart", "regionaler_zusatz", "ort", "plz", "land", "vermarktungsstatus", "preisAufAnfrage"); if ($field == "kaufpreis" || $field == "warmmiete") { if ($currentEstate['preisAufAnfrage'] == 'Ja') { $value = esc_html('Preis auf Anfrage', 'oo_theme'); } } ``` ### Desired state If the “Price on request” Checkbox is ticked in onOffice enterprise the value should display “Preis auf Anfrage” in the frontend of the website instead of the actual price.
yeneastgate commented 1 year ago

@fredericalpers I finished this issue, you can watch the video below and give me feedback

https://user-images.githubusercontent.com/104892108/232424141-cd6caf4b-91e3-4fc5-90fb-b8f6251a7010.mp4

fredericalpers commented 1 year ago

@yeneastgate the basic rent does not seem to be included? From my experience, most real estate agents in Germany will use basic rent as the value displayed.

dai-eastgate commented 1 year ago

@fredericalpers Do you want to add any other types of prices? such as "Price, Rental income per month, Rent for parking space..."

Or only support for "kaufpreis, warmmiete, kaltmiete"

Please specify the all type prices Which you want to support the "price on request" feature. Thanks!

I fixed for "basic rent" case. This demo video

https://user-images.githubusercontent.com/106214469/232729902-ad4c7c82-f696-4a99-987f-97f0c3169168.mp4

fredericalpers commented 1 year ago

@fredericalpers Do you want to add any other types of prices? such as "Price, Rental income per month, Rent for parking space..."

Or only support for "kaufpreis, warmmiete, kaltmiete"

Please specify the all type prices Which you want to support the "price on request" feature. Thanks!

I fixed for "basic rent" case. This demo video

price_on_request.mp4

I'm contacting our IT Department to figure out which fields are connected to the Checkbox and will update you, hopefully shortly.

fredericalpers commented 1 year ago

@dai-eastgate @yeneastgate

The following values are supposed to be overwritten with "Price on request" if activated:

yennt89 commented 1 year ago

@fredericalpers Thanks, I will fix it.

yeneastgate commented 1 year ago

@fredericalpers I updated. You can watch the video below.

https://user-images.githubusercontent.com/104892108/233900524-cde77606-ed3f-4d21-bc06-cb823ee31d0b.mp4

fredericalpers commented 1 year ago

@fredericalpers I updated. You can watch the video below.

price_on_request.mp4

thank you! looks good to me :)

fredericalpers commented 1 year ago

@yeneastgate after discussing it with my colleagues, we would like to implement further changes.

preisAufAnfrage-layout preisAufAnfrage-layout-detail preisAufAnfrage-old

yeneastgate commented 1 year ago

@fredericalpers yes, I will implement it.

yeneastgate commented 1 year ago

@fredericalpers I would like to confirm a point. In the frontend, the "detail" page also displays the "similar estates list". However, we currently only apply the "Price on request" feature for the "detail" page, while the "similar estates list" still shows the actual price. Therefore, do you want to use the "price-on-request" feature for the similar estate as well?

fredericalpers commented 1 year ago

@fredericalpers I would like to confirm a point. In the frontend, the "detail" page also displays the "similar estates list". However, we currently only apply the "Price on request" feature for the "detail" page, while the "similar estates list" still shows the actual price. Therefore, do you want to use the "price-on-request" feature for the similar estate as well?

@yeneastgate yes the similar estates also should habe the price on request feature.

yeneastgate commented 1 year ago

@fredericalpers I modified the "Price on request" feature as requested. Please take a look at the videos below and tell me your opinion. https://files.fm/u/drz2t95kn

fredericalpers commented 1 year ago

@fredericalpers I modified the "Price on request" feature as requested. Please take a look at the videos below and tell me your opinion. https://files.fm/u/drz2t95kn

Thank you, looks good to me! :) We will test it on our end now