onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

New release = old bug again #496

Closed fredericalpers closed 1 year ago

fredericalpers commented 1 year ago

Discussed in https://github.com/onOffice-Web-Org/oo-wp-plugin/discussions/495

Originally posted by **fredericalpers** April 11, 2023 After releasing the new Plugin Version we encountered an old bug again. In enterprise deactivated fields will lead to critical error.
fredericalpers commented 1 year ago

@dai-eastgate Please try to squeeze this in so we can release a Hotfix. If I remember we had this fixed before by "skipping" the deactivated fields.

dai-eastgate commented 1 year ago

@dai-eastgate Please try to squeeze this in so we can release a Hotfix. If I remember we had this fixed before by "skipping" the deactivated fields.

I will check and fix it

dai-eastgate commented 1 year ago

@fredericalpers Can you be more specific about where the error occurs?

fredericalpers commented 1 year ago

@fredericalpers Can you be more specific about where the error occurs?

@dai-eastgate In v4.10 of the plugin, in enterprise all deactivated fields will cause an critial error in WordPress when used in a property list. See the attachment below:

deactived

dai-eastgate commented 1 year ago

@fredericalpers we miss "skipping" the deactivated fields When this fields add to "FilterableFields" image

I fixed at https://github.com/onOffice-Web-Org/oo-wp-plugin/pull/497 Pls check again. This demo video. ex: ind_2082_Feld_ObjTech40

https://user-images.githubusercontent.com/106214469/231369407-cd379d18-cf7a-46e0-acdf-2f7bdfe5984e.mp4

fredericalpers commented 1 year ago

Perfect, thank you :)

andernath commented 1 year ago

Thanks @dai-eastgate for your fast fix. :) Estatelist works ✔ But we still have problem while saving in backend if some fields are inactive in enterprise. It doesn't matter if the fields are filterable or not.

2023-04-12 10_20_53-‹ WP-Plugin Test — WordPress

2023-04-12 10_21_08-WordPress › Fehler

dai-eastgate commented 1 year ago

yes, I will check it now

yennt89 commented 1 year ago

@andernath @fredericalpers I fixed it. This is demo video, pls check again

https://user-images.githubusercontent.com/61687197/231768409-af4e09b4-fb78-44da-9b8f-aa3963e61ea9.MP4

fredericalpers commented 1 year ago

Thank you! We will check again and give our feedback