search

onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

Missing field types #634

Closed fredericalpers closed 5 months ago

fredericalpers commented 10 months ago

Regarding Issue 557.

"Some fields are not displayed in the correct format "default value" feature for that field type. The reason is that the "field type" API result responses of these fields are not covered in the source code. These are the fields whose type is not covered in the code. Please check the file listed by name and type as follows.."

Current state

The following field keys & types are missing as mentioed in the issue above:

Desired state

The following field keys & types should be added to the code:

The field keys & types do not have to be added:

yeneastgate commented 10 months ago

@fredericalpers

  1. For "urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:date" type fields:

    • We must submit "value for these fields" as "DateTime" format to create the correct data in Enterprise. example: "yy/mm/dd", "yy-mm-dd" or "yy.mm.dd"
    • In the master branch, these fields display in both the front-end and back-end as image below: image => Would you like to keep this format or use a "Datepicker" format as shown in the image below? image

  2. For "urn:onoffice-de-ns:smart:2.5:dbAccess:dataType:tinyint" type fields:

    • We must submit "value for these fields" as "boolean" format example: "0" corresponds to "No" or "1" corresponds to "Yes"

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/104892108/56cef991-b845-4deb-9311-1413e2d08024

=> Would you like to display them in a "BOOLEAN" format as shown in the image? image

fredericalpers commented 10 months ago

@yeneastgate I will be able to give you feedback on this tomorrow, thank you :)

fredericalpers commented 10 months ago

@yeneastgate As for no.1 please implement the suggested date picker. Make sure it has a good usability on mobile devices and it works in all browsers. E.g. Chrome, Firefox, Safari etc.

As for no.2 is it possible to use radio buttons instead of a select? This way we can show both possible values and its easier to change for customers.

yeneastgate commented 10 months ago

@fredericalpers I will try implementing it and will update the results for you ASAP.

yeneastgate commented 9 months ago

As for no.1 please implement the suggested date picker. Make sure it has a good usability on mobile devices and it works in all browsers. E.g. Chrome, Firefox, Safari etc.

@fredericalpers The "date picker" feature has been already implemented in the Estate List. I tested and it works fine. Mobile devices: iPhone 13 (1170 x 2532) iPhone 7 (750 x 1334) iPhone 6 (750 x 1334) iPhone XR (414x 896) Ipad Gen 7 (2160 x 1620) Realme 11 Pro (1080 x 2412)

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/104892108/c5ab535f-00fe-4686-b99b-a62e79875dd3

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/104892108/3bb2bce4-9055-4fd9-9ccc-164620a3c0c7

Browsers: Chrome: version 117, 107 Edge: version 117, 107 Opera: version 102, 98 Safari: 16.5.1

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/84e45fbe-4fde-43c2-bce4-44fe08a113d5

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/104892108/4de6e489-8884-4fbe-8fc3-6f29710b2edb

Do you want me to test it on any other specific browsers or mobile versions?

yeneastgate commented 9 months ago

@fredericalpers

  1. If there's no need for further testing, I will implement the 'date picker' feature similar to the one in the Estate List
  2. .This is the list of fields that will be implemented.

list-fields => It will take 6 days to implement and test it. Thanks!

fredericalpers commented 9 months ago

@yeneastgate please go ahead and implement the date picker and the missing field list, thank you :)

yeneastgate commented 9 months ago

@yeneastgate please go ahead and implement the date picker and the missing field list, thank you :)

OK. I will implement it.

yeneastgate commented 9 months ago

@fredericalpers I checked and found that: To change from "input text" to "date picker" and type "tinyInt" to "radio button". image image => Can I edit the "fields.php" file?

fredericalpers commented 9 months ago

@yeneastgate please go ahead :)

yeneastgate commented 9 months ago

@fredericalpers Currently, in the form, I see fields with the "Date" or "DateTime" type Which display as "text field"

image image

=> Please confirm: Do you need to change those types "text field" to "Date picker"? image

yeneastgate commented 9 months ago

@fredericalpers I have added types for the missing fields:

Please watch my video demo and let me know your opinion. Thanks! https://files.fm/u/u7puprntxt