onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

Clear cache with admin bar quick action on multisites #661

Closed fredericalpers closed 9 months ago

fredericalpers commented 10 months ago

Current State

With multisites, the cache cannot be cleared with the quick action "Clear cache" in the admin bar. It'll lead to a URL like: https://multisite-domain/wp-admin/onoffice-clear-cache which causes an error as seen below.

Not Found
The requested URL was not found on this server.

Desired State

The quick action "Clear cache" should also work for multisites.

dai-eastgate commented 9 months ago

@fredericalpers For this issue, I am working on it and will get back to you soon.

yeneastgate commented 9 months ago

@fredericalpers I fixed this bug. Please watch my video test on WordPress Multisite and let me know your opinion. Thanks! This feature still works fine on multisites. https://files.fm/u/5r9q3mz5tz#/view/893bvprrdy

Note: This feature still works fine on single-site. https://files.fm/f/3rmacn26jw

fredericalpers commented 9 months ago

@yeneastgate looks good to me, is there anyway you can also test this on an actual WordPress Multisite or am I missing something?

yeneastgate commented 9 months ago

@fredericalpers I fixed this bug. Please watch my video test on WordPress Multisite and let me know your opinion. Thanks! This feature still works fine on multisites. https://files.fm/u/5r9q3mz5tz#/view/893bvprrdy

@fredericalpers there anyway I can also test this on an actual WordPress Multisite

fredericalpers commented 9 months ago

@yeneastgate I'm blind, sorry :D thank you for the quick fix.

Edit: Moved this to 4.16 for the review and being able to release it soon.