search

onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

Form can not be sent with unfilled required fields and enabled recaptcha #669

Closed andernath closed 9 months ago

andernath commented 10 months ago

While testing #648 I have found 2 bugs in forms that have required fields and use reCAPTCHA.

Major bug 1:

Form can not be sent. See Picture 03. To reproduce the bug:

Now the sending button turn disbaled because you did not fill all required fields, but no hint will be shown. There is no way to enable the sending button again.

Minor bug 2:

Styling of required field hint is wrong. Picture 02. To reproduce the bug:

Hint will be displayed but not with the same text and style like Picture 01.

Picture 01 (Hint if no recapcha is enabled and user did not fill required field) 01_required_hint Picture 02 02_required_hint_with_recapcha Picture 03 03_required_hint_recapcha_not_loaded

dai-eastgate commented 10 months ago

@andernath I will check and let you know asap. Thanks!

dai-eastgate commented 10 months ago

@fredericalpers @andernath

Major bug 1:

I have fixed this bug. Please watch my video demo

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/2ff9406d-c353-4507-9cbd-e75afbb1eaaf

Minor bug 2:

I have fixed this bug. Please watch my video demo

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/6a769b3a-87b7-450e-b86a-63c4f13bdff9

Note: I have implemented "reCAPTCHA correctly for each form" to follow in this linked document (https://developers.google.com/recaptcha/docs/display#explicit_render)

andernath commented 10 months ago

Good work @dai-eastgate I will review and test ist later.