onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

Can't remove / delete secrets and keys #677

Closed fredericalpers closed 3 months ago

fredericalpers commented 8 months ago

Initiative

Improve the usability of the onOffice for WP-Websites Plugin for a better user experience.

Epic

Make the removing/editing of settings possible.

User story

As a real estate agent using the onOffice for WP-Websites Plugin, I need the ability to fully remove my Google reCAPTCHA credentials from the plugin configuration. Currently, while I can delete the reCAPTCHA site key, I'm unable to delete the secret key. I can only replace it with an invalid value, which is not ideal for usability reasons.

As I focus on providing a secure and user-friendly experience on my real estate website, I have previously integrated Google reCAPTCHA to prevent spam and ensure the safety of user interaction. However, situations may where I need to entirely remove these credentials due to changes in security protocols or other considerations. With the current plugin configuration, I face limitations when attempting to remove the Google reCAPTCHA secret key. Therefore, I require a solution that allows me to:

As a real estage agent its crucial for me to have control over the security settings of my website. The ability to fully remove Google reCAPTCHA credentials from the onOffice for WP-Websites Plugin would offer me the flexibility and security assurance I need to manage my website effectively.

Tasks

dai-eastgate commented 8 months ago

@fredericalpers

  • User interface modification: Add the type="password" attribute and a toggle (eye icon) to show / not show the credentials.

Do you want to add the type="password" attribute for both keys (site key and secret key)?

  • User interface modification: Adjust the plugin user interface to include an option for completely removing Google reCAPTCHA credentials.

I will add a "delete button" like the image below. Do you agree with me? image

  • Confirmation prompt: Integrate a confirmation prompt or dialogue box to confirm the user's intent before deleting the reCAPTCHA credentials.

Please provide me with the text content of the confirmation prompt. I will implement the demo text like the dialogue box in the image below. image

fredericalpers commented 8 months ago

@dai-eastgate

Do you want to add the type="password" attribute for both keys (site key and secret key)?

please go ahead and add the type password attribute for both keys.

I will add a "delete button" like the image below. Do you agree with me?

if possible please add the button below the input fields for the keys and make it red, so that it is clearly seperated.

Please provide me with the text content of the confirmation prompt. I will implement the demo text like the dialogue box in the image below.

Please use the following text for the confirmation prompt: Would you like to permanently delete the site key and the secret?

dai-eastgate commented 8 months ago

@dai-eastgate

Do you want to add the type="password" attribute for both keys (site key and secret key)?

please go ahead and add the type password attribute for both keys.

I will add a "delete button" like the image below. Do you agree with me?

if possible please add the button below the input fields for the keys and make it red, so that it is clearly seperated.

Please provide me with the text content of the confirmation prompt. I will implement the demo text like the dialogue box in the image below.

Please use the following text for the confirmation prompt: Would you like to permanently delete the site key and the secret?

@fredericalpers I estimate it will take 2 days to implement and test. Thank!

dai-eastgate commented 8 months ago

@fredericalpers Please watch my video demo and let me know your opinions. Thanks!

https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/8e461d0f-d8fa-4508-9092-f59a19d7b664

fredericalpers commented 8 months ago

@dai-eastgate looks good to me! thank you :)