yeneastgate
commented
10 months ago @fredericalpers Below are some of my analyses about those ways "Load the Maps JavaScript API" I. Use "Dynamic Library Import"
- Advantage:
- Only load required scripts
- Improve performance load page in Front-end:
- Disadvantage:
- Cannot inherit current source code.
- Affect backward compatibility: Need to create mapID
=> Old users will have difficulty creating mapID
- Implement: We have implemented this solution in the branch https://github.com/onOffice-Web-Org/oo-wp-plugin/tree/proper-loading-of-google-maps-js-api-in-onoffice-plugin. You can test and review it.
II. Use "Direct Script Loading Tag"
-
Advantage:
- Can inherit current source code.
- Easily add more callbacks according to Google's recommendations
-
Disadvantage:
- Performance: May slow down page load time if many libraries are loaded.
-
Implement:
- We have implemented this solution in the branch https://github.com/onOffice-Web-Org/oo-wp-plugin/tree/proper-loading-of-google-maps-js-api-in-onoffice-plugin-v2. You can test and review it.
III. Use the NPM js-api-loader package: not suitable because it is not necessary to install additional packages
- Although "Use "Dynamic Library Import"" is recommended by Google, I suggest you choose "Use "Direct Script Loading Tag" because it can inherit the current source code.
fredericalpers
Initiative
Improve the onOffice for WP-Websites Plugins' usability and performance
Epic
Implement proper loading patterns for Google Maps JavaScript API
User story
As a real estate agent using the onOffice for WP-Websites Plugin, I am concerned about the current implementation of loading the Google Maps JavaScript API directly without a callback, as it may lead to race conditions and suboptimal performance. To ensure a more reliable and efficient integration, I seek the implementation of the correct loading patterns recommendet by Google for the Google Maps API.
To address this concern and align with best practices recommenden by Google, I propose the adoption of correct loading patterns for the Google Maps API.
Tasks
By implementing the correct loading patterns for the Google Maps JavaScript API, the onOffice for WP-Websites Plugin can enhance its performance, reliability and overall user experience, ensuring a seamless integration with Google Maps functionalities.