search

onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

onOffice menu item disappears in the WP backend #769

Closed fredericalpers closed 3 months ago

fredericalpers commented 4 months ago

Initiative

Bug fixing for the onOffice for WP-Websites Plugin

Epic

Restore visibility of "onOffice" Menu Item in WordPress Admin Sidebar.

User Story

As a user managing my website, I've encountered a bug where the "onOffice" menu item disappears from the left menu bar editing pages. This issue has arisen after updating to version 4.18 of the onOffice for WP-Websites plugin and is in direct correlation with Commit 43305 backend performance. The disappearance of the "onOffice" menu item disrupts my workflow and makes it challenging to access important functionalities provided by the plugin.

To ensure seamless usability and functionality of the onOffice WordPress integration, I propose resolving the bug.

Tasks

By addressing this bug, users will regain access to the "onOffice" menu item in the WordPress admin sidebar, allowing them to efficiently manage their website's functionalities without disruption.

Menu item: https://snipboard.io/dGBkru.jpg Menu item dissapeared: https://snipboard.io/bxKehR.jpg

dai-eastgate commented 4 months ago

@fredericalpers yes, I will check it now.

yeneastgate commented 4 months ago

@fredericalpers We have checked and found that the cause of this bug was that we were still using some plugin features on the edit page. However, we returned $pDI before those functions were executed.

We also did not expect this problem because coincidentally when using the editing page, we used the full-screen editing feature.

image We did not detect this bug during testing. We apologize for this problem.

Here is the list of plugin features used in the edit page

  1. Menu at the office image

  2. Bar menu at the office image

  3. Cache in onoffice bar menu image

  4. Save page (add shortcode) image

  5. Delete page (remove shortcode) image

We've narrowed the impact down to just edit_page in the condition code. image

Therefore other feature pages will not be affected. so the functionality of wp-onoffice-plugin on the client site is not affected

We have refactored the code. You can review and test it in this branch 45733-onoffice-menu-item-disappears-in-the-wp-backend. Please watch the demo video and let me know your idea. https://files.fm/u/tx36erpaay#/view/3zx4ywvr6e.