onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

Extending Pagination Features for Theme Compatibility #850

Open fredericalpers opened 1 week ago

fredericalpers commented 1 week ago

Extending Pagination Features for Theme Compatibility

User Story

As a user of the onOffice WordPress plugin, I want the pagination feature to be compatible with WordPress themes' pagination, so that I can use my preferred theme's pagination style seamlessly.

In the release of version 4.20, the pagination improvements (#695) were introduced, but they currently work only with the pagination system of the onOffice for WP-Websites plugin. In version 4.21, an extra HTML <div> (#849) will be removed, and further enhancements are needed to ensure that the pagination feature can also be used with WordPress themes' built-in pagination systems.

With these enhancements, users of the onOffice WordPress plugin will be able to utilize their preferred WordPress theme's pagination system seamlessly, enhancing the overall integration and user experience.

Task / Requirements

dai-eastgate commented 4 days ago

@fredericalpers After investigation, I found the following issues:

  1. The reason the pagination function does not work with multi-shortcode is that: In the template file code, we have not added the pagination code if the user chooses the "Pagination By WP Theme" option image

=> So currently the pagination function is showing using the "wp_link_pages" function in the content.php file of the WordPress theme which is active image

  1. However, each different WordPress theme uses the "wp_link_pages" function in the content.php file differently. image

=> We cannot fulfill this requirement "The pagination feature must be compatible with the default pagination styles and systems provided by WordPress themes." => We only add pagination features with common formats (compatible with default pagination styles) for WordPress themes as follows image

You can see the following demo: https://files.fm/f/38tqv6y2g6