search

onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites
https://wp-plugin.onoffice.com
GNU General Public License v3.0
9 stars 9 forks source link

51857 Implementation of a checkbox to change the form behavior #878

Open yeneastgate opened 3 months ago

yeneastgate commented 3 months ago

related to https://github.com/onOffice-Web-Org/oo-wp-plugin/issues/871 changed log:

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10363238446

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/Form.php 0 1 0.0%
<!-- Total: 13 14 92.86% -->
Totals Coverage Status
Change from base Build 10280139031: 0.02%
Covered Lines: 8450
Relevant Lines: 10637
💛 - Coveralls
fredericalpers commented 2 weeks ago

nach Rücksprache für v5.3 vorgezogen.

github-actions[bot] commented 1 week ago

Steps to install the approved version:

  1. Download onoffice-5.2-27-g6e729133-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11779667169.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.
fredericalpers commented 1 week ago

Hi @yeneastgate Unfortunately, the feature is not working as expected. I have already reset the database version, but the checkbox still doesn't seem to influence the form’s behavior.

Is there anything else that might need updating or any files that should be modified to ensure the checkbox functions correctly?

Thank you!

yeneastgate commented 1 week ago

@fredericalpers To resolve the issue, the template must be changed, and only the user can perform this action. Please update the template and test it again.

fredericalpers commented 1 week ago

@fredericalpers To resolve the issue, the template must be changed, and only the user can perform this action. Please update the template and test it again.

Hi @yeneastgate Thank you for pointing this out. I'm not entirely sure which specific adjustments need to be made to the template to resolve the issue. Could you please provide a screenshot of the result in the frontend with the default template and a more detailed explanation of the necessary changes? Thanks in advance for your assistance!

yeneastgate commented 4 days ago

@fredericalpers Show form as modal has been activated.

image image

Show form as modal has been deactivated. image

In the video, I have shown the steps you can watch to understand better.

https://github.com/user-attachments/assets/813ae9c0-4878-4e60-88e0-b6ba6c72ff6c

fredericalpers commented 1 day ago

Hi @yeneastgate ,

It seems there might be a misunderstanding here. In the comments above, you mentioned changes in the template. Therefore we need a detailed guide, including screenshots or a video, to replicate these changes correctly.

At the moment, the feature does not work for us, no matter what steps we take. These changes should be available in the template.dist folder when uploading the zip file of this branch. Even when copying all the files to the personalized folder the feature does not work. Please provide clear instructions on how to proceed so we can ensure everything is working as intended.

Thank you for your support!

yeneastgate commented 1 day ago

@fredericalpers You can watch the video for a more detailed understanding. If any steps are missing or unclear, please let me know, and I will review them.

https://github.com/user-attachments/assets/0ae05d3c-c0b9-44b7-a3b2-e8f79f2de437

Here are the steps to follow. If they are not working, you can refer to the video:

  1. Template Requirement: Only the ownerleadgeneratorform template has this functionality.
  2. Backward Compatibility: If you are using a custom template like onoffice-personalized, you will need to update the ownerleadgeneratorform file.
  3. Plugin Version Check: Ensure the plugin version is correct if you cannot activate or deactivate the checkbox in the backend.

Note: If the issue persists, please provide me with a public link where the shortcode form is used, and the ownerleadgeneratorform template is selected, so I can investigate and identify the cause.

fredericalpers commented 1 day ago

@yeneastgate Thank you for your update! I noticed that while the checkbox now successfully changes the behaviour in the frontend, it's no longer possible to submit the forms. Specifically, no emails are being sent, and no data record are being created. The error code 185 ("Missing or invalid record ids") appears in the debug log. Could you please investigate and address this issue? Let me know if you need additional details or assistance!

debug (23).log

yeneastgate commented 14 hours ago

@yeneastgate Thank you for your update! I noticed that while the checkbox now successfully changes the behaviour in the frontend, it's no longer possible to submit the forms. Specifically, no emails are being sent, and no data record are being created. The error code 185 ("Missing or invalid record ids") appears in the debug log. Could you please investigate and address this issue? Let me know if you need additional details or assistance!

debug (23).log

@fredericalpers I will check it.

yeneastgate commented 10 hours ago

@fredericalpers I tested again on my local and also on this link (https://testinstanz-fal.onofficeweb.com/formular-leadgenerator/) and could not reproduce the bug (the form was submitted successfully). If possible please provide me with a video of the bug reproducing so I can continue to investigate. Thanks!

yeneastgate commented 8 hours ago

@fredericalpers Please check if your enterprise exists:

https://github.com/user-attachments/assets/84d9cc7e-6ecf-4a9b-99b5-fdff96b990c8

github-actions[bot] commented 3 hours ago

Steps to install the approved version:

  1. Download onoffice-5.2-33-gba9fbe3e-please-unpack.zip from https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/runs/11973995024.
  2. Unpack the downloaded file to get another .zip file.
  3. Upload that inner .zip file to WordPress.