onOffice-Web-Org / oo-wp-plugin

onOffice for WP-Websites

https://wp-plugin.onoffice.com

GNU General Public License v3.0

9 stars 9 forks source link

"Helper Class" with Translatable Text for Address Detail Page #946

Open fredericalpers opened 2 weeks ago

fredericalpers commented 2 weeks ago

"Helper Class" with Translatable Text for Address Detail Page

User story

Implement a "helper class" with translatable text that will handle cases when the address detail page is accessed without a dataset number. This functionality should be built similarly to the implementation on the real estate detail page.

https://github.com/onOffice-Web-Org/oo-wp-plugin/blob/4e26567b83efd088cd44114d946448c3438bd7ff/plugin/Controller/ContentFilter/ContentFilterShortCodeEstateDetail.php#L112

Please ensure consistency with existing project patterns and code style. Feel free to reuse code from the property detail page where applicable.

dai-eastgate commented 2 weeks ago

@fredericalpers Would you like me to implement this feature as seen in the property details? Here’s how it would work:

Case 1: If the user is logged in, show a random address ID.
Case 2: If the user is not logged in, do not display the address ID.

If this is correct, should I also change the terminology—for example, replacing "estate" with "address"?

fredericalpers commented 2 weeks ago

@dai-eastgate yes, please go ahead and implement it as it is with properties. Please change the terminology to "address"

dai-eastgate commented 2 weeks ago

@fredericalpers If no addressID is found, please provide me a document link, similar to when an estateID is not found. https://wp-plugin.onoffice.com/en/first-steps/estate-lists/

fredericalpers commented 2 weeks ago

@dai-eastgate we do not have a specific part about adresslists in our documentation yet. Please link to the main page for now, thank you :)

dai-eastgate commented 1 week ago

@fredericalpers I have implemented it. Please take a look at my demo video and let me know your opinions. Thanks!

[Video Link removed]

fredericalpers commented 1 week ago

@dai-eastgate thank you :)

🔴 I had to remove the video, since you showed your excel sheet with login credentials. Please be more careful with posting these videos and showing login credentials and API Tokens in the future. Especially if you have other peoples login showing too ;)🔴

dai-eastgate commented 1 week ago

@fredericalpers Sorry. I will be carefull next time