fredericalpers commented 2 weeks ago

Correct handling of Umlauts and Special Characters during language switch

User Story

As a user of a multilingual website, I want the correct conversion and display of umlauts (ä, ö, ü) and special characters when switching between languages (e.g., from German to English and back to German). This ensures that no incorrect URLs are generated, which could lead to 301 redirects, providing a consistent user experience and improving SEO performance.

Implementing this user story ensures that umlauts and special characters are correctly handled in the URL structure of a multilingual website, preventing SEO issues caused by 301 redirects and maintaining a seamless user experience.

Task / Requirements

[x] When switching from German to English and back to German, umlauts like ä, ö, and ü must be consistently displayed as ae, oe, and ue. Returning to the original language (e.g., English to German) must not change or lose these characters (no transformation from “schoene” to “schone”).
[x] Special characters, such as “ß,” should be handled correctly by converting them to “ss.”
[x] The language switch should not trigger automatic 301 redirects due to incorrect character conversions in the URL.
[x] URLs must be encoded in a way that ensures the correct and user-friendly display of characters in all supported languages.
[x] Umlauts and special characters should remain readable in the URL and must not require encoding transformations (e.g., %C3%A4 for “ä”), except when necessary for browser compatibility.

redirects1

dai-eastgate commented 2 weeks ago

@fredericalpers I tested the master branch and did not encounter the bug you mentioned. The bug only reappeared when I commented out that specific line of code.

Please check your code again to see if these two lines are present.

https://github.com/user-attachments/assets/1035398f-ae3e-4e65-a715-64780cfa70c9

fredericalpers commented 2 weeks ago

We didn't alter the plugin. The lines are not commented out.

Feel free to check our plugin demo website: https://wp-plugin-demo.onoffice.com/de/immobilien/details/27-schoene-immobilie-in-aachen/

dai-eastgate commented 2 weeks ago

We didn't alter the plugin. The lines are not commented out.

Feel free to check our plugin demo website: https://wp-plugin-demo.onoffice.com/de/immobilien/details/27-schoene-immobilie-in-aachen/

We will continue to check this bug.

dai-eastgate commented 2 weeks ago

@fredericalpers We have found the cause of the bug and fixed it. Please take a look at my demo video and let me know your opinions. Thanks!

https://github.com/user-attachments/assets/32a8cb24-c780-448d-bac4-17cb0070249d

fredericalpers commented 2 weeks ago

Seems to be working fine now! Thank you, we will review this as soon as possible :)

onOffice-Web-Org / oo-wp-plugin