onPoster / app

A decentralized web application for interacting with ERC-3722 – Poster.
https://poster-app.on.fleek.co/
GNU General Public License v3.0
16 stars 6 forks source link

Ensure we do not index events that have more than 300 characters #3

Closed 0xjjpa closed 3 years ago

0xjjpa commented 3 years ago

Currently blocked by ETHPoster/contract#15 since we need to know which subgraph we'll use. I'm super happy to stick with @crazyrabbitLTC 's one, but would then need to create a PR that changes

https://github.com/ETHPoster/subgraph/blob/main/src/mapping.ts#L15

to something that skips the event if event.params.content > 300

crazyrabbitLTC commented 3 years ago

Feel free to make prs against the subgraph if you need to move faster.

I think one question I have is if our JSON format is actually optimal, it’s quite expensive as it’s basically 2x the size of the data itself because we have to pay for all the JSON formatting.

On Tue, Aug 3, 2021 at 10:06 AM Jose Aguinaga @.***> wrote:

Currently blocked by ETHPoster/contract#15 https://github.com/ETHPoster/contract/issues/15 since we need to know which subgraph we'll use. I'm super happy to stick with @crazyrabbitLTC https://github.com/crazyrabbitLTC 's one, but would then need to create a PR that changes

https://github.com/ETHPoster/subgraph/blob/main/src/mapping.ts#L15

to something that skips the event if event.params.content > 300

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ETHPoster/app/issues/3#issuecomment-891876354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOZEXMAACXNBXNIGDSVL43T27ZWJANCNFSM5BKQXP7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Sent from Gmail Mobile

crazyrabbitLTC commented 3 years ago

Also don’t let me be a blocker, I am on paternity and have a full time gig at withTally.com so if you need to move fast, move fast!

On Tue, Aug 3, 2021 at 10:06 AM Jose Aguinaga @.***> wrote:

Currently blocked by ETHPoster/contract#15 https://github.com/ETHPoster/contract/issues/15 since we need to know which subgraph we'll use. I'm super happy to stick with @crazyrabbitLTC https://github.com/crazyrabbitLTC 's one, but would then need to create a PR that changes

https://github.com/ETHPoster/subgraph/blob/main/src/mapping.ts#L15

to something that skips the event if event.params.content > 300

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ETHPoster/app/issues/3#issuecomment-891876354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOZEXMAACXNBXNIGDSVL43T27ZWJANCNFSM5BKQXP7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Sent from Gmail Mobile