onagre-launcher / onagre

A general purpose application launcher for X and wayland inspired by rofi/wofi and alfred
MIT License
511 stars 27 forks source link

fix link #42

Closed LuckyTurtleDev closed 2 years ago

cocogitto-bot[bot] commented 2 years ago

:x: Found 0 compliant commit and 1 non-compliant commits in f39fb6fbb7f8c78523c34fc27c7c6ad25b8f4722...f39fb6fbb7f8c78523c34fc27c7c6ad25b8f4722.

Commit f39fb6fbb7f8c78523c34fc27c7c6ad25b8f4722 by @Lukas1818 is not conform to the conventional commit specification :

oknozor commented 2 years ago

Thank you @Lukas1818,

Can you please amend your commit message so it respect the conventional commits specification ?

msrd0 commented 2 years ago

It's sad to see that projects unnecessarily raise the bar pretty high for simple pull requests like this one. Reading such a long documentation is definitely not worth the time investment for a one-line fix like this one. Feel free to disagree.

oknozor commented 2 years ago

I do disagree,

I really think raising the bar from the start and holding to it as many benefits in the long run. Successful projects use these kind of conventions for a reason.

Respecting the convention is mandatory here because version are automatically bumped from the commit history, changelogs are generated using the convention and it makes the git log human readable and meaningful.

Also I really don't see in what way amending a commit to make it meaningful could be see as "raising the bar", It's just hygiene to me.

I am a bit biased because I maintain the tool we use here.

I hope there is no hard feeling though.