search

onagre-launcher / onagre

A general purpose application launcher for X and wayland inspired by rofi/wofi and alfred
MIT License
511 stars 27 forks source link

WIP: Chore: Update to iced 0.12 #79

Closed nerdachse closed 4 months ago

nerdachse commented 4 months ago

This is not yet done, as

1) for some reason the scrollbar/container is not filling the whole height as before.

As you can see, only one item is always shown (and you can see the scrollbar is not tall enough)

screenshot_16 02 2024-13 55 28

I've played around a bit, but it has been years since I experimented with iced and I couldn't figure out why it's not behaving as wanted.

2) https://github.com/onagre-launcher/onagre/compare/main...nerdachse:onagre:main#diff-b2db4128ee8d3fd19ff317f148c1b2d9e8e6fe7bcd711ca80b5617c21dd5b97cR160

Pretty self-explanatory.

I am opening this PR nonetheless because it may help as a base for someone else, or even me, when I have time to work on this again.

Apart from opening the PR I want to take a moment and say: Thank you! I love onagre!

oknozor commented 4 months ago

Hey @nerdachse thanks a lot for the PR, I moved it to #80 and fixed the issue you mentioned. Unfortunately that does not seem to fix the transparency issue. But still, keeping iced up to date is nice.