onaio / collect

Copy of collect with checkin history fixed
https://github.com/opendatakit/opendatakit
1 stars 2 forks source link

Form update background service #28

Open mberg opened 8 years ago

mberg commented 8 years ago

A background service should run checking to see if any forms were updated every 10 minutes. This will not work if there isn't connectivity.

If a new form or updated form is detected a standard android alert should be triggered. Also, the count of new forms/updated forms should update on the home page.

rowo commented 8 years ago

This means run in the background when the app is open right, not when it's closed? What's wrong with just having it check when the app is launched?

rowo commented 8 years ago

Does this need a toggle on/off? Takes up data right?

jasonrogena commented 7 years ago

Reenabled this feature. Now using MQTT, that should make for faster propagation of updates.

I added two preference though; one for toggling ON/OFF the service (ON by default), and the other for auto downloading forms (OFF by default). A form is auto-downloaded only if it there aren't non-finalised forms on the device.

screen_2_resize

Also added a dialog for warning users when they start filling a form that has a pending update. Useful in cases where the notification for an update came through but the device was unable/is still updating the form.

screen_1_resize

rowo commented 7 years ago

@jasonrogena What is happening when "Auto check for form updates" is checked? I don't think the label or description is clear. If it is unchecked, how do you check manually?

jasonrogena commented 7 years ago

@rowo When the "Auto check for form updates" is checked, the app is constantly checking for form form updates in onaio/onadata. Is 'Constantly check when form updates are made available' a better description in the settings page?

mberg commented 7 years ago

Is this currently working? If so that's awesome On Thu, Jan 12, 2017 at 1:04 PM Jason Rogena notifications@github.com wrote:

@rowo https://github.com/rowo When the "Auto check for form updates" is checked, the app is constantly checking for form form updates in onaio/onadata. Is 'Constantly check when form updates are made available' a better description in the settings page?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/onaio/collect/issues/28#issuecomment-272122999, or mute the thread https://github.com/notifications/unsubscribe-auth/AADiQRfZuopwrP_DoNOVGfFrwT4TEf-oks5rRfqRgaJpZM4G5wkK .

jasonrogena commented 7 years ago

It is, but some functionality will have to be built in core https://github.com/onaio/onadata/issues/866 before it can go out

rowo commented 7 years ago

@jasonrogena So for "constantly check", does that mean checking when the app is open or running in the background?

If the app isn't running in the background, it won't check, right?

Is there a frequency that it checks?

jasonrogena commented 7 years ago

@rowo It will continue checking for updates in the background, when the app is closed. Hard to attach a 'frequency' to it. It uses the same technology chat apps use to deliver messages, so when an update is made available, all devices with the form should receive the update immediately

rowo commented 7 years ago

@jasonrogena by "receive the update immediately" does that mean (1) the form auto-syncs (i.e. gets the new version and replaces the old one) as well or (2) just downloads the form so you can choose whether to update or (3) receives notice that there is an update so the form still has to be grabbed

Asking because I think of this how getting forms works more like email because it's something you fetch/get. Messages you don't really think of as getting them, they just come. So I think most people would think about it like me. So it might be something closer to background check, or form fetch, or sync, depending on what is actually happening here.

rowo commented 7 years ago

@jasonrogena Ok I reread your messages I think I get it. It's just a broadcast message that a form update is available. If that's the case, yeah your suggestion might be good. What do you think of:

Auto check for form updates Constantly check for form updates and be notified when available. Turning off reduces data and power consumption.

jasonrogena commented 7 years ago

@rowo Yeah, it's a notice that there's a new update. The form is only automatically downloaded if the "Auto update forms" preference is checked. Your label and description are much better, thanks

bmalina commented 7 years ago

Client has requested for this feature: https://app.intercom.com/a/apps/xzsimrke/respond/inbox/bmalina@ona.io/conversations/9666317330