Forms shared with a user not showing up on the formlist

onaio / collect

Copy of collect with checkin history fixed

https://github.com/opendatakit/opendatakit

1 stars 2 forks source link

Forms shared with a user not showing up on the formlist #29

Open smusula opened 8 years ago

smusula commented 8 years ago

This is what happens:

Scenario One:

The user A created a project and uploaded several forms to the project. user A then shared this forms with the user B, assigned the Can submit permission level;
User B logs on Ona Collect, enables Show forms shared with you option in the Ona Collect settings;
Tries to download forms and successfully downloads the shared forms;

Scenario Two:

The user C shares the project Health Facilities with the user D, assigns Can submit permission level;
User D logs on Ona Collect, enables Show forms shared with you option in the Ona Collect General settings;
On Ona Collect the forms are missing on the formlist hence one cannot download them;
On ODK Collect the forms can be seen on the formlist and can be downloaded;

jmunene commented 8 years ago

With Ona Collect, when using https://odk.ona.io/[formowner-username] , the account that the project was shared with, can be able to download the forms. Is this a bug or it was designed this way. On ODK Collect it works perfect.

rowo commented 8 years ago

It should be considered a bug since Ona Collect should work exactly the same as ODK Collect when Show shared forms is checked. @mberg can you confirm you did not define a different spec?

jmunene commented 8 years ago

@rowo I changed the server url from https://odk.ona.io to https://ona.io and it worked as it should. Could also be an issue with the API

jmunene commented 8 years ago

@rowo Here is the issue I created on core https://github.com/onaio/core/issues/801

ukanga commented 8 years ago

That url needs to be checked again, and I would stick to odk.ona.io, ona.io as much as it is supposed to always work has a level of abstraction that has performance implications.

pld commented 8 years ago

Because it works as it should with ODK Collect this sounds like a Collect issue not an API issue.

rowo commented 8 years ago

I think I misunderstood a previous comment from Jonathan. Seems like Peter is right — something on Ona Collect is off.

jmunene commented 8 years ago

@rowo @pld When I use the KLL url (http://nhrpapi.cbs.gov.np/), it works perfect on Ona Collect as on ODK Collect. Am not saying there's nothing wrong with Ona Collect, but we also need to find out why its behaving this way. I did the QA on Ona Collect and it was working ok.

imwongela commented 8 years ago

We had designed this to be this way. In ODK Collect if a user appends their username at the end of the url they can only see their forms and not forms shared with them. So the setting can be overridden since some of ODK Collect users where used to this way of filtering.

mberg commented 8 years ago

Confirmed this is a bug.

@imwongela - all forms that are shared with you. Not just the forms that are /mberg should show up.

Right now only the forms in my mberg project are visible if I sign in with mberg and have the server point to odk.ona.io. I think what you are saying would apply if the odk.ona.io/mberg is being used but in this case it's not.

mberg commented 8 years ago

I believe it was working properly in the earlier release of collect. So I think it's a result of some logic changing. @jmunene please call @imwongela to discuss