9: Code cleanup and Addressing Test Debt - Adding Unit Tests for Custom Endpoints PractitionerDetails and LocationHierarchy

rehammuzzamil commented 11 months ago

Resolves https://github.com/onaio/fhir-gateway-plugin/issues/9 IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves [link to issue]

Engineer Checklist

[x] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[x] I have run mvn spotless:check to check my code follows the project's style guide
[x] I have run mvn clean test to confirm all new and existing tests passed.
[ ] I ran mvn clean package right before creating this pull request.

rehammuzzamil commented 11 months ago

@rehammuzzamil I tried running the tests with report generation but that seems to no longer get generated correctly and we get 0% coverage. Could you please confirm on your end and investigate/fix before we merge? Can you please share the steps to generate report at my end? @ndegwamartin

ndegwamartin commented 10 months ago

@rehammuzzamil I've fixed the issue with the code coverage reporting, apparently it was being caused by the Jupiter unit tests dependency introduced in the PR here.

onaio / fhir-gateway-extension

9: Code cleanup and Addressing Test Debt - Adding Unit Tests for Custom Endpoints PractitionerDetails and LocationHierarchy #19