115 add physical type - Githubissues

onaio / fhir-tooling

A command line utility to support FHIR Core content authoring

Other

2 stars 1 forks source link

Closed TraciebelWairimu closed 8 months ago

TraciebelWairimu commented 8 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #115

Engineer Checklist

[ ] I have run ./gradlew spotlessApply to check my code follows the project's style guide
[ ] I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

Wambere commented 8 months ago

@dubdabasoduba @f-odhiambo confirming that both type and physicalType are limited to only Building and Jurisdiction, is this correct?

dubdabasoduba commented 8 months ago

@Wambere @TraciebelWairimu these columns can hold other items

PhysicalType - https://hl7.org/fhir/R4B/valueset-location-physical-type.html Type - https://terminology.hl7.org/3.1.0/ValueSet-v3-ServiceDeliveryLocationRoleType.html - This list might be too long maybe we can provide a way on the CSV to provide the required options.

I am okay with merging this then we can handle the items on the comments later

Wambere commented 8 months ago

@dubdabasoduba ok, let me create a separate issue for that