onaio / fhir-tooling

A command line utility to support FHIR Core content authoring
Other
2 stars 2 forks source link

Validate StructureMap #281

Closed Wambere closed 1 month ago

Wambere commented 3 months ago

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #199

Engineer Checklist

ndegwamartin commented 1 month ago

Tested it out and it returns a successful validation even when I give it an incorrect questionnaire json file path

ndegwamartin commented 1 month ago

Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the QuestionnaireResponse generated here for validation - https://github.com/onaio/fhir-tooling/blob/199-validate-sm/efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java#L106-L115 leading to the exception here :

Screenshot 2024-10-17 at 19 10 03

ndegwamartin commented 1 month ago

Additionally we should refactor to remove duplicates across the project or move any potentially reusable code to util classes

sharon2719 commented 1 month ago

Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the QuestionnaireResponse generated here for validation - https://github.com/onaio/fhir-tooling/blob/199-validate-sm/efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java#L106-L115 leading to the exception here :

Screenshot 2024-10-17 at 19 10 03

For this to run you need to have the hapi-fhir-jpaserver running locally. I have included this information in the ReadMe.

ndegwamartin commented 1 month ago

Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the QuestionnaireResponse generated here for validation - https://github.com/onaio/fhir-tooling/blob/199-validate-sm/efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java#L106-L115 leading to the exception here : Screenshot 2024-10-17 at 19 10 03

For this to run you need to have the hapi-fhir-jpaserver running locally. I have included this information in the ReadMe.

Since we intend to run this via CI for the automation how do we intent to handle this case?