search

onaio / fhir-tooling

A command line utility to support FHIR Core content authoring
Other
2 stars 1 forks source link

Enforce FHIR validation #80

Closed Wambere closed 8 months ago

Wambere commented 8 months ago

We added resource validation to the FHIR resources repository but have not really enforced it since at the moment the check always passes, and one has to go to actions > workflow > validate > Run validation in order to see the results

This issue is to update the workflow such that it actually fails if the validation fails

This issue will also track the change of the Validation support modules run to only having the DefaultProfileValidationSuport as default

Other validation support modules can be found here

Wambere commented 8 months ago

@ndegwamartin @dubdabasoduba I know you had reservations about the current validation being too strict, I have tested the function with each of the modules separately and it looks like most of the "validation/errors" are actually from the DefaultProfileValidationSupport

The CommonCodeSystemsTerminologyService and InMemoryTerminologyServerValidationSupport only gave a few errors, all around invalid JSON content. So really won't make a difference removing them

Any reservations around moving forward and actually failing PRs?

pld commented 8 months ago

I support moving forward and enabling this, people can still override merge