Enhanced Efsity Validation on FHIR Resources Repo CI

onaio / fhir-tooling

A command line utility to support FHIR Core content authoring

Other

2 stars 1 forks source link

Enhanced Efsity Validation on FHIR Resources Repo CI #83

Closed ndegwamartin closed 5 months ago

ndegwamartin commented 8 months ago

Currently, we have DefaultProfileValidation integrated to the fhir-resources repo continuous integration process. We need to add the (various) other types of validation that Efsity supports in order to catch any such issues early on.

Before that we need a conversation with the stakeholders (Digital Health T/PMs) on which of the items listed in the Efsity CI integration discussion here should be enforced as fatal errors (Errors that must be fixed thus causing the CI build to fail)

[x] Facilitate Conversation + Decision making aforementioned with T/PMs
[x] Integration to the FHIR Resources repository CI workflow
[ ] Update on the #fhir channel once its live

Wambere commented 6 months ago

(link to docs on how to run validation)

A couple of issues when it comes to integrating this into the FHIR resources repo CI:

We have recently made changes to only validate the files in the current PR and not the whole project. So what happens in cases where the composition file is not part of the PR? Should we go out of the PR to find it in the repo? or just ignore the check?
Ideally this would be easier if we were already using the same/agreed upon folder structure, so that at least we know where to look for the composition file

pld commented 6 months ago

I think we ignore it

ndegwamartin commented 6 months ago

After a chat with @Wambere I think we should not reduct the validation scope. That refactor was done to speed up merging by only validating what the PR changed.

I think the project teams should dedicate the time to fix, especially clean up all unused references in their configs once and for all. That way we don't need to refactor the validator and plus we end up with lean project configs.