search

onaio / fhir-tooling

A command line utility to support FHIR Core content authoring
Other
2 stars 1 forks source link

Validate only files in PR #89

Closed Wambere closed 7 months ago

Wambere commented 7 months ago

A couple of people have raised concern that the validation implementation is currently validating not just the files pushed in the editor's PR, but other files in the project. This was by design so that we can eventually validate and update all the files in the repository

However there are special cases where the editor doesn't have enough context or bandwidth to update / fix all the other files in the project

A possible solution / recommendation would be to revert validation to only affect pushed files and require the author to ensure that they are valid, and then have some sort of weekly "Hour of Validation" or something like that where every engineer picks a file or two from the different projects and validates it.

Is this something we can agree on? Are there any other ideas / recommendations on how to go about this?

pld commented 7 months ago

Yea reasonable, it should be a config option, whether to validate in PR or validate all, so new projects can turn on all others can do only in PR

Wambere commented 7 months ago

it should be a config option, whether to validate in PR or validate all, so new projects can turn on all others can do only in PR

I think with new projects this will be automatic since all files will be part of the first PR and thus all validated, so we shouldn't run into a situation where we have anything invalid

aurangzaibumer commented 7 months ago

thanks for creating an issue. This was much needed.