Legend anexing - Githubissues

onaio / gisida

JavaScript library that converts MapSpec layers to beautiful, interactive maps using Mapbox GL

http://gisida.onalabs.org/

Apache License 2.0

10 stars 3 forks source link

Legend anexing #485

Closed kahummer closed 4 years ago

kahummer commented 4 years ago

The pr adds to store ability to remove legend item on legend close.

[x] Add Ability to remove legend to store

Fix: https://github.com/onaio/irfsomalia/issues/896

kelvin-muchiri commented 4 years ago

@kahummer Was there a need to introduce new changes to the store? Can't we make use of activeLayerIds, then only display legends for layers that are in activeLayerIds?

kahummer commented 4 years ago

Was there a need to introduce new changes to the store? Can't we make use of activeLayerIds, then only display legends for layers that are in activeLayerIds?

@kelvin-muchiri Didn't think about that it works really well-using activeLayerIds. Will close this since we can render legends based on activeLayerIds .