onaio / hki-vas-dashboard

HKI VAS Dashboard
1 stars 0 forks source link

Marker Display #27

Closed geoffreymuchai closed 10 years ago

geoffreymuchai commented 10 years ago
geoffreymuchai commented 10 years ago
Current Progress

Display of single markers and individual points for Cameroon data works but the other datapoints do not render on the map when loaded through omnivore.

Still to be done
geoffreymuchai commented 10 years ago

Current progress:

Pending issue:

mberg commented 10 years ago

@geoffreymuchai to answer a few of your q's.

Take a look at the zoomToFeature function. I think we'll want to do that when you click the marker. What you would pass to it is the layer and do a bounds around that.

It's a bit tricky as we'll need to make sure the layer disappears when we change rounds and zoom out. So I think basing this off of the zoom level will be key. We also don't want to load all the points across all sites for a round as we'd be loading 9 points per site.

On the omnivore issue I really am not sure what the issue is. Have you tried loading a different single data set? Did that work? Or is only a problem when you are loading multiple datasets at once.

Couple of other things missing

mberg commented 10 years ago

I just looked at the PECS data layer and realized we only have data for vita and also for gender and age. I just pushed up code that distinguishes by gender (m/f). Maybe we want to add a toggle that does age group (1/2).

I can't really see much difference though so maybe just focusing on vita as a single parameter is enough. i'm trying to see if we can get heatmap working to see if it helps make better sense of what's going on.

geoffreymuchai commented 10 years ago

The data points now look better thanks to the improvements you have made. I will look into the zoomToFeature implementation you have suggested and will factor in the expected behaviour.

Concerning the omnivore issue, I have tried loading different data sets yesterday but it hasn't worked. I will investigate further to find out what could be causing this.

On Tue, Mar 18, 2014 at 8:00 PM, Matt Berg notifications@github.com wrote:

I just looked at the PECS data layer and realized we only have data for vita and also for gender and age. I just pushed up code that distinguishes by gender (m/f). Maybe we want to add a toggle that does age group (1/2).

I can't really see much difference though so maybe just focusing on vita as a single parameter is enough. i'm trying to see if we can get heatmap working to see if it helps make better sense of what's going on.

Reply to this email directly or view it on GitHubhttps://github.com/onaio/hki-vas-dashboard/issues/27#issuecomment-37958621 .

geoffreymuchai commented 10 years ago

@mberg I now have most of the other data pecs points loading. I had to rename some of them to match the expected code_hasc code.

The reason omnivore was not loading the files is because the files contained rows which had invalid values in the latitude and longitude columns.

mberg commented 10 years ago

yep that's what i figured. looking at it now. beautiful!

On Wed, Mar 19, 2014 at 2:16 PM, Geoffrey Muchai notifications@github.comwrote:

@mberg https://github.com/mberg I now have most of the other data pecs points loading. I had to rename some of them to match the expected code_hasc code.

The reason omnivore was not loading the files is because the files contained rows which had invalid values in the latitude and longitude columns.

Reply to this email directly or view it on GitHubhttps://github.com/onaio/hki-vas-dashboard/issues/27#issuecomment-38048722 .

mberg commented 10 years ago

i'm a happy happy man.

nice work

On Wed, Mar 19, 2014 at 2:24 PM, Matt Berg mberg@ona.io wrote:

yep that's what i figured. looking at it now. beautiful!

On Wed, Mar 19, 2014 at 2:16 PM, Geoffrey Muchai <notifications@github.com

wrote:

@mberg https://github.com/mberg I now have most of the other data pecs points loading. I had to rename some of them to match the expected code_hasc code.

The reason omnivore was not loading the files is because the files contained rows which had invalid values in the latitude and longitude columns.

Reply to this email directly or view it on GitHubhttps://github.com/onaio/hki-vas-dashboard/issues/27#issuecomment-38048722 .

geoffreymuchai commented 10 years ago

Thanks