onaio / kujaku

Mapping and check-in library for Android using MapBox SDK
https://ona.io
BSD 2-Clause "Simplified" License
18 stars 13 forks source link

Add Wmts Layers Feature #224

Closed eotin closed 5 years ago

eotin commented 5 years ago

Possibility to read Capabilities from a Wmts service Retrieve availables layers Add Layers to the MapView

ekigamba commented 5 years ago
  1. I tried using this this map https://services.arcgisonline.com/arcgis/rest/services/World_Imagery/MapServer/WMTS/1.0.0/WMTSCapabilities.xml and past a certain point, I get data not available tiles. I checked the WMTS capabilities document and it seems the min and max zoom are defined. Do you think we can fix this by setting the max zoom or min zoom for the specific WMTS layers or all WMTS layers in that source? What do you think?
  2. It seems we will not be support any other tile sizes such as 512 from this code since the tile size is a constant 256. This map is old and no longer supported but it has tiles of size 512. What do you think? I tried using it as it is and I can only see half the world on the activity WMTSActivity
ekigamba commented 5 years ago

Yea, that's OK by me

On Mon, Jan 21, 2019 at 4:43 PM eotin notifications@github.com wrote:

@eotin commented on this pull request.

In sample/src/main/java/io/ona/kujaku/sample/activities/WmtsActivity.java https://github.com/onaio/kujaku/pull/224#discussion_r249454217:

+import io.ona.kujaku.views.KujakuMapView; + +public class WmtsActivity extends BaseNavigationDrawerActivity { +

  • private static final String TAG = WmtsActivity.class.getName();
  • private KujakuMapView kujakuMapView;
  • @Override
  • protected void onCreate(Bundle savedInstanceState) {
  • super.onCreate(savedInstanceState);
  • Mapbox.getInstance(this, BuildConfig.MAPBOX_SDK_ACCESS_TOKEN);
  • kujakuMapView = findViewById(R.id.wmts_mapView);
  • WmtsCapabilitiesService wmtsService = new WmtsCapabilitiesService(getString(R.string.wmts_capabilities_url));

you're right. i'm wondering if it is not a typo in the specification ?? So, i suggest to accept both writing for "style" and "Style" and don't modifiy the rest. Is it ok for you ?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/onaio/kujaku/pull/224#discussion_r249454217, or mute the thread https://github.com/notifications/unsubscribe-auth/AeS2OxPQ-LlVtUyRr-NZTTZQl5tE691Oks5vFcQXgaJpZM4ZDKDa .