search

onaio / kujaku

Mapping and check-in library for Android using MapBox SDK
https://ona.io
BSD 2-Clause "Simplified" License
18 stars 13 forks source link

Add Offline map download helper #225

Closed ekigamba closed 5 years ago

ekigamba commented 5 years ago

Fixes #216

vincent-karuri commented 5 years ago

Should there be an activity demonstrating downloads using this helper?

Or generally, how should this be tested?

vincent-karuri commented 5 years ago

Does this fix #223 as written in the issue description?

ekigamba commented 5 years ago

Does this fix #223 as written in the issue description?

Nope, supposed to before I was unassigned

ekigamba commented 5 years ago

Should there be an activity demonstrating downloads using this helper? Or generally, how should this be tested?

I will add this functionality to the MainActivity as a second way to do this if this is okay with you

vincent-karuri commented 5 years ago

Should there be an activity demonstrating downloads using this helper? Or generally, how should this be tested?

I will add this functionality to the MainActivity as a second way to do this if this is okay with you

This would be ok. In this pr, right?

ekigamba commented 5 years ago

Should there be an activity demonstrating downloads using this helper? Or generally, how should this be tested?

I will add this functionality to the MainActivity as a second way to do this if this is okay with you

This would be ok. In this pr, right?

Yeap, it already is