onaio / kujaku

Mapping and check-in library for Android using MapBox SDK
https://ona.io
BSD 2-Clause "Simplified" License
18 stars 11 forks source link

Request for Location to be turned on only whenever one clicks on my location widget #227

Closed githengi closed 5 years ago

githengi commented 5 years ago

User is being requested to enable Location services whenever Geowidget is launched instead of when my location widget is clicked

ekigamba commented 5 years ago

Sometimes the GPS takes time to get the current user's location, I therefore start getting updates as soon as the user starts using the GeoWidget(warm it) view so that when they click on the button, we just move to their location.

In case this is used with internet, then the response for location would be pretty quick, however for offline situations(using GPS hardware only), this might vary a lot and be disappointing.

I am not sure about your use case, but I guess we can make this configurable so that the host application can control how this happens and document it as usual.

What do you think? @githengi

githengi commented 5 years ago

The Geowidget can make when to prompt for location services to be turned on configurable.

The default can be as is currently.

ekigamba commented 5 years ago

Cool 👍

githengi commented 5 years ago

This will be implemented in Reveal v2 and Geowidget V3