onaio / kujaku

Mapping and check-in library for Android using MapBox SDK
https://ona.io
BSD 2-Clause "Simplified" License
18 stars 11 forks source link

Enable arrow line and boundary layers to be updated #278

Closed ekigamba closed 5 years ago

ekigamba commented 5 years ago

Fixes #277

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1310


Changes Missing Coverage Covered Lines Changed/Added Lines %
library/src/main/java/io/ona/kujaku/views/KujakuMapView.java 1 10 10.0%
library/src/main/java/io/ona/kujaku/layers/BoundaryLayer.java 16 27 59.26%
library/src/main/java/io/ona/kujaku/layers/ArrowLineLayer.java 19 35 54.29%
sample/src/main/java/io/ona/kujaku/sample/activities/FociBoundaryActivity.java 0 24 0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/CaseRelationshipActivity.java 0 28 0.0%
<!-- Total: 38 126 30.16% -->
Files with Coverage Reduction New Missed Lines %
library/src/main/java/io/ona/kujaku/views/KujakuMapView.java 2 28.98%
sample/src/main/java/io/ona/kujaku/sample/activities/CaseRelationshipActivity.java 4 0.0%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 1279: 0.4%
Covered Lines: 1722
Relevant Lines: 5176

💛 - Coveralls
githengi commented 5 years ago

image

Rename to Disable arrows showing relationship button to Disable/Remove Arrows, otherwise one button should be on top of another.

ekigamba commented 5 years ago

Stacked the buttons and changed button text